feat(expo,react): Make Signal hooks the default #6946
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| "react/use-session-list.mdx", | ||
| "react/use-session.mdx", | ||
| "react/use-sign-in-signal.mdx", | ||
| "react/use-sign-in-1.mdx", |
There was a problem hiding this comment.
Is this something that we control ? what does 1 mean ?
There was a problem hiding this comment.
This is for Typedoc. Since there are now two useSignIn hooks (one from the root and one from the legacyit adds the-1` suffix. I don't know if this is controllable.
| <ClerkProvider | ||
| routerPush={(to: string) => router.push(to)} | ||
| routerReplace={to => router.replace(to)} | ||
| clerkJSUrl={process.env.EXPO_PUBLIC_CLERK_JS_URL} |
There was a problem hiding this comment.
is this updated on purpose ?
There was a problem hiding this comment.
Yes, previously the expo tests used the production version of clerk-js rather than the version from the current PR.
| if (clerkExpoPath?.startsWith('link:')) { | ||
| return clerkExpoPath.replace('link:', ''); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is for local testing. Locally the package.json has the link: protocol. However I'm unable to get the tests to work correctly locally 😓
| @@ -1,4 +1,4 @@ | |||
| import { useSignIn, useSignUp } from '@clerk/react'; | |||
| import { useSignIn, useSignUp } from '@clerk/react/legacy'; | |||
There was a problem hiding this comment.
Is this just for this PR, or are we leasing the package like that ?
There was a problem hiding this comment.
As of right now this is the intent. If we have time I'll take a look and see if we need to update the API of the useOAuth hook.
There was a problem hiding this comment.
I think we should dogfood the new hooks as much as we can before the release. Usually that's the strategy.
| 'use client'; | ||
|
|
||
| import { useSignUp } from '@clerk/nextjs'; | ||
| import { useSignUp } from '@clerk/nextjs/legacy'; |
There was a problem hiding this comment.
Are we creating a new use-sign-up.md that wll use the new hook ?
There was a problem hiding this comment.
This is used in our typedoc comments. Our new comments don't (yet) use this example, so I haven't created one yet.
4 participants
Description
This PR moves our experimental
useSignInSignalanduseSignUpSignalhooks into their rightful place as the defaultuseSignInanduseSignUphooks. It moves the previous hooks to a@clerk/react/legacyexport. It also updates Expo's use of the legacy hooks to the new export.It adds the
/legacyexport to the Next.js, React Router, Tanstack Start, and Expo SDKs.It also deletes the
@clerk/remixpackage and all supporting files that referenced it.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change